Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support freeform-sort drop animation #434

Merged
merged 1 commit into from
Sep 29, 2024

Conversation

BLumia
Copy link
Member

@BLumia BLumia commented Sep 29, 2024

自由排序模式支持拖放动画(暂无拖拽过程中实时动画)

Log:

自由排序模式支持拖放动画(暂无拖拽过程中实时动画)

Log:
@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • FreeSortProxyModel的构造函数中,setModel方法被重载为直接调用sort方法,这可能是一个错误,应该检查setModel方法的具体实现。
  • FreeSortProxyModelfilterAcceptsRow方法中,条件判断逻辑可能存在问题,当前的修改将m_pageId == -1的情况也视为接受行,这可能不符合预期。
  • MultipageSortFilterProxyModelfilterAcceptsRow方法中,条件判断逻辑被修改,增加了对m_pageId的检查,这可能是为了支持页面切换功能。
  • SortProxyModellessThan方法中,virtual关键字被添加,这可能是为了标记该方法需要被子类重写。

是否建议立即修改:

  • 需要确认FreeSortProxyModelsetModel方法的行为是否正确,并修复可能的错误。
  • 需要检查MultipageSortFilterProxyModel的页面切换逻辑是否与预期一致,并确保过滤条件的修改是正确的。
  • 需要确保SortProxyModellessThan方法的修改是符合Qt QML规范的,并且子类需要正确重写该方法。

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: BLumia, tsic404

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@BLumia BLumia merged commit 125faf6 into linuxdeepin:master Sep 29, 2024
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants